Hi Ram, Reviewed-by: Andi Shyti <[email protected]>
but just two notes on the patchstyle, no need to resend: 1. would be nice to have [PATCH v2...] otherwise it's difficult to see if I'm reading the correct version. (I don't see the difficulty 'git format-patch -v 2...') > Add a new platform flag, has_64k_pages, to mark the requirement of 64K > GTT page sizes or larger for device local memory access. > > Also implies that we require or at least support the compact PT layout > for the ppGTT when using 64K GTT pages. > > v2: More explanation for the flag [Thomas] > > Signed-off-by: Stuart Summers <[email protected]> > Signed-off-by: Ramalingam C <[email protected]> > Reviewed-by: Lucas De Marchi <[email protected]> 2. the tag part has a temporal meaning: Stuart has written the patch, Lucas has reviewed it and you are sending it, therefore, the correct order should be: Signed-off-by: Stuart Summers <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Signed-off-by: Ramalingam C <[email protected]> Thanks, Andi
