On Mon, 11 Oct 2021 15:02:45 +0800, Yunfei Dong wrote:
> Adds decoder dt-bindings for mt8192.
>
> Signed-off-by: Yunfei Dong <[email protected]>
> ---
> v7: Re-write dtsi for hardware architecture changed
> ---
> .../media/mediatek,vcodec-comp-decoder.yaml | 193 ++++++++++++++++++
> 1 file changed, 193 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:44:7:
[warning] wrong indentation: expected 4 but found 6 (indentation)
./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:88:7:
[warning] wrong indentation: expected 2 but found 6 (indentation)
./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:193:7:
[error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:
properties:compatible: [{'enum': ['mediatek,mt8192-vcodec-dec',
'mediatek,mtk-vcodec-lat', 'mediatek,mtk-vcodec-core']}] is not of type
'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:
$id: relative path/filename doesn't match actual path or filename
expected:
http://devicetree.org/schemas/media/mediatek,vcodec-comp-decoder.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml:
ignoring, error in schema: properties: compatible
warning: no schema found in file:
./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.yaml
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dts:29.13-20:
Warning (ranges_format): /example-0/vcodec_dec@16000000:ranges: empty "ranges"
property but its #address-cells (2) differs from /example-0 (1)
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dts:29.13-20:
Warning (ranges_format): /example-0/vcodec_dec@16000000:ranges: empty "ranges"
property but its #size-cells (2) differs from /example-0 (1)
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dts:33.13-66:
Warning (dma_ranges_format): /example-0/vcodec_dec@16000000:dma-ranges:
"dma-ranges" property has invalid length (24 bytes) (parent #address-cells ==
1, child #address-cells == 2, #size-cells == 2)
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dts:34.24-57.15:
Warning (unit_address_vs_reg): /example-0/vcodec_dec@16000000/vcodec_lat: node
has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dts:59.25-85.15:
Warning (unit_address_vs_reg): /example-0/vcodec_dec@16000000/vcodec_core:
node has a reg or ranges property, but no unit name
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dt.yaml:
example-0: vcodec_dec@16000000:reg:0: [0, 369098752, 0, 4096] is too long
From schema:
/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dt.yaml:0:0:
/example-0/vcodec_dec@16000000: failed to match any schema with compatible:
['mediatek,mt8192-vcodec-dec']
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dt.yaml:0:0:
/example-0/vcodec_dec@16000000/vcodec_lat: failed to match any schema with
compatible: ['mediatek,mtk-vcodec-lat']
Documentation/devicetree/bindings/media/mediatek,vcodec-comp-decoder.example.dt.yaml:0:0:
/example-0/vcodec_dec@16000000/vcodec_core: failed to match any schema with
compatible: ['mediatek,mtk-vcodec-core']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1539139
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
