Am 08.07.21 um 19:37 schrieb Daniel Vetter:
From: Christian König <[email protected]>

Drivers also need to to sync to the exclusive fence when
a shared one is present.

Signed-off-by: Christian König <[email protected]>
[danvet: Not that hard to compile-test on arm ...]
Signed-off-by: Daniel Vetter <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: [email protected]
Cc: [email protected]

Wondering a bit why you have that in this patch set now.

But any objections that we push this now?

Thanks,
Christian.

---
  drivers/gpu/drm/msm/msm_gem.c | 16 +++++++---------
  1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 141178754231..d9c4f1deeafb 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -812,17 +812,15 @@ int msm_gem_sync_object(struct drm_gem_object *obj,
        struct dma_fence *fence;
        int i, ret;
- fobj = dma_resv_shared_list(obj->resv);
-       if (!fobj || (fobj->shared_count == 0)) {
-               fence = dma_resv_excl_fence(obj->resv);
-               /* don't need to wait on our own fences, since ring is fifo */
-               if (fence && (fence->context != fctx->context)) {
-                       ret = dma_fence_wait(fence, true);
-                       if (ret)
-                               return ret;
-               }
+       fence = dma_resv_excl_fence(obj->resv);
+       /* don't need to wait on our own fences, since ring is fifo */
+       if (fence && (fence->context != fctx->context)) {
+               ret = dma_fence_wait(fence, true);
+               if (ret)
+                       return ret;
        }
+ fobj = dma_resv_shared_list(obj->resv);
        if (!exclusive || !fobj)
                return 0;

Reply via email to