Re: [PATCH 0/4] mgag200: Various cleanups

[Thomas Zimmermann]

Hi Sam

Am 01.07.21 um 19:58 schrieb Sam Ravnborg:

Hi Thomas,

On Thu, Jul 01, 2021 at 02:43:12PM +0200, Thomas Zimmermann wrote:

Cleanup several nits in the driver's init code. Also move constant
data into the RO data segment. No functional changes.

Tested on mgag200 HW.

Thomas Zimmermann (4):
   drm/mgag200: Don't pass flags to drm_dev_register()
   drm/mgag200: Inline mgag200_device_init()

This patch drop a redundant error message too - it had helped me if the
changelog had said so but whatever.

Sure, I'll add it to the log.

   drm/mgag200: Extract device type and flags in mgag200_pci_probe()
   drm/mgag200: Constify LUT for programming bpp

Full serie is:
Acked-by: Sam Ravnborg <s...@ravnborg.org>

Thanks for the review.

Best regards
Thomas

        Sam

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature