Hi, On Thu, Apr 29, 2021 at 5:58 PM Linus Walleij <[email protected]> wrote: > > On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson <[email protected]> > wrote: > > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > > avoid excessive unprepare / prepare") we started using pm_runtime, but > > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > > them now. > > > > Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid > > excessive unprepare / prepare") > > Reported-by: Bjorn Andersson <[email protected]> > > Signed-off-by: Douglas Anderson <[email protected]> > > This patch as such: > Reviewed-by: Linus Walleij <[email protected]> > > Notice however: you turn on pm runtime pm_runtime_enable() > in panel_simple_probe() but are you ever turning it off in > panel_simple_remove()? > > I think pm_runtime_disable(); need to be added there?
I'm a bit confused. You're saying that I need to add pm_runtime_disable() to panel_simple_remove()? Doesn't this patch do that? This patch adds two calls to pm_runtime_disable(). One of those is in the probe error path and the other one is in panel_simple_remove(). -Doug _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
