On Sun, Jan 24, 2021 at 9:15 AM Simon Ser <[email protected]> wrote:
> On Sunday, January 24th, 2021 at 5:40 AM, Mario Kleiner < > [email protected]> wrote: > > > According to the CTA 861.G spec, HDMI_STATIC_METADATA_TYPE1 is > > not 1, but zero, so fix this enum. > > > > While this doesn't cause problems in the kernel yet, as the > > constant isn't actively used by drivers yet, it did create > > confusion while debugging HDR problems in yours truly, and > > also potential bugs in userspace components, as the wrong > > enum propagates to components, e.g., like it did already > > into intel-gpu-tools (tests/kms_hdr.c) or is used as wrong > > reference when writing future new userspace HDR components > > like compositors. > > > > Fixes: fbb5d0353c62 ("drm: Add HDR source metadata property") > > Signed-off-by: Mario Kleiner <[email protected]> > > Cc: Uma Shankar <[email protected]> > > Cc: Shashank Sharma <[email protected]> > > Cc: Ville Syrjälä <[email protected]> > > Sadly I think it's too late for this. Some user-space (like Kodi) > already has copied over the kernel definitions, and libdrm already has > a release with the wrong value. > But it still needs to be fixed if we want working HDR. I thought libdrm copies the definitions from the kernel periodically, so the fix should propagate?
_______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
