On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul <[email protected]> wrote:

> Nvidia hardware doesn't actually support using tiling formats with the
> cursor plane, only linear is allowed. In the future, we should write a
> testcase for this.
>
> Fixes: c586f30bf74c ("drm/nouveau/kms: Add format mod prop to 
> base/ovly/nvdisp")
> Cc: James Jones <[email protected]>
> Cc: Martin Peres <[email protected]>
> Cc: Jeremy Cline <[email protected]>
> Cc: Simon Ser <[email protected]>
> Cc: <[email protected]> # v5.8+
> Signed-off-by: Lyude Paul <[email protected]>

Together with [1], this patch allows me to run unpatched modifier-aware
user-space successfully, without a cursor visual glitch. drm_info
correctly reports the new modifier list, and wlroots logs confirm that
a flavor of NVIDIA_BLOCK_LINEAR_2D is used for the primary buffers and
LINEAR is used for cursor buffers.

Code looks good to me as well.

Reviewed-by: Simon Ser <[email protected]>

[1]: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3724
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to