Hi Mikko, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tegra-drm/drm/tegra/for-next] [also build test WARNING on tegra/for-next linus/master v5.9-rc8 next-20201007] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201008-034403 base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next config: arm64-randconfig-r021-20201008 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d1d8ae7100ec3c7e1709addb7b3ec6f9ad0b44f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/c4f5ec983027f2b19e6854a362e23a79e1630100 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201008-034403 git checkout c4f5ec983027f2b19e6854a362e23a79e1630100 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>): >> drivers/gpu/host1x/uapi.c:227:8: warning: variable 'file' is uninitialized >> when used here [-Wuninitialized] fput(file->file); ^~~~ drivers/gpu/host1x/uapi.c:204:24: note: initialize the variable 'file' to silence this warning struct sync_file *file; ^ = NULL 1 warning generated. -- >> drivers/gpu/host1x/fence.c:105:6: warning: no previous prototype for >> function 'host1x_fence_signal' [-Wmissing-prototypes] void host1x_fence_signal(struct host1x_syncpt_fence *f) ^ drivers/gpu/host1x/fence.c:105:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void host1x_fence_signal(struct host1x_syncpt_fence *f) ^ static 1 warning generated. vim +/file +227 drivers/gpu/host1x/uapi.c 199 200 static int dev_file_ioctl_create_fence(struct host1x *host1x, void __user *data) 201 { 202 struct host1x_create_fence args; 203 unsigned long copy_err; 204 struct sync_file *file; 205 int fd; 206 207 copy_err = copy_from_user(&args, data, sizeof(args)); 208 if (copy_err) 209 return -EFAULT; 210 211 if (args.reserved[0]) 212 return -EINVAL; 213 214 if (args.id >= host1x_syncpt_nb_pts(host1x)) 215 return -EINVAL; 216 217 args.id = array_index_nospec(args.id, host1x_syncpt_nb_pts(host1x)); 218 219 fd = host1x_fence_create_fd(&host1x->syncpt[args.id], args.threshold); 220 if (fd < 0) 221 return fd; 222 223 args.fence_fd = fd; 224 225 copy_err = copy_to_user(data, &args, sizeof(args)); 226 if (copy_err) { > 227 fput(file->file); 228 return -EFAULT; 229 } 230 231 return 0; 232 } 233 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
