On Fri, 2 Oct 2020 18:41:43 -0500 Rob Herring <[email protected]> wrote:
> Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: Stephen Boyd <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Bjorn Andersson <[email protected]> > Cc: Baolin Wang <[email protected]> > Cc: Guenter Roeck <[email protected]> > Cc: Jonathan Cameron <[email protected]> > Cc: Mauro Carvalho Chehab <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Lee Jones <[email protected]> > Cc: Ulf Hansson <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Vinod Koul <[email protected]> > Cc: Liam Girdwood <[email protected]> > Cc: Mark Brown <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Daniel Lezcano <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Rob Herring <[email protected]> > --- Hi Rob, Acked-by: Jonathan Cameron <[email protected]> # for iio However, one of these made me wonder if the binding was simply wrong... (definitely highlights why we should have additionalProperties: false where ever possible). ... > diff --git > a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > index abd8d25e1136..4c1c083d0e92 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > @@ -47,11 +47,17 @@ properties: > vddio-supply: > description: Regulator that provides power to the bus > > + spi-max-frequency: true > + spi-cpha: true > + spi-cpol: true It isn't completely unheard of for a device to operate in multiple SPI modes, but it does seem to be fairly unusual. I took a look at the datasheet and at least from the provided timing diagrams, these are both required in SPI mode. http://invensense.tdk.com/wp-content/uploads/2020/09/DS-000292-ICM-42605-v1.5.pdf That doesn't make the binding wrong as such, but we could be tighter in checking this! I'll add this to my list to take a closer look at sometime soonish. Thanks. Jonathan > + > required: > - compatible > - reg > - interrupts > > +additionalProperties: false > + > examples: > - | _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
