On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter <[email protected]> wrote: > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > simple dma device that can't guarantee write protection. Which is also > what all the callers are using. > > So just simplify this. > > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Inki Dae <[email protected]> > Cc: Joonyoung Shim <[email protected]> > Cc: Seung-Woo Kim <[email protected]> > Cc: Kyungmin Park <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Pawel Osciak <[email protected]> > Cc: Marek Szyprowski <[email protected]> > Cc: Tomasz Figa <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Oded Gabbay <[email protected]> > Cc: Omer Shpigelman <[email protected]> > Cc: Tomer Tayar <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Pawel Piskorski <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > drivers/misc/habanalabs/common/memory.c | 3 +-- > include/linux/mm.h | 2 +- > mm/frame_vector.c | 4 ++-- > 5 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 967a5cdc120e..ac452842bab3 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct > g2d_data *g2d, > goto err_free; > } > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > - g2d_userptr->vec); > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > if (ret != npages) { > DRM_DEV_ERROR(g2d->dev, > "failed to get user pages from userptr.\n"); > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c > b/drivers/media/common/videobuf2/videobuf2-memops.c > index 6e9e05153f4e..9dd6c27162f4 100644 > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long > start, > unsigned long first, last; > unsigned long nr; > struct frame_vector *vec; > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > first = start >> PAGE_SHIFT; > last = (start + length - 1) >> PAGE_SHIFT; > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long > start, > vec = frame_vector_create(nr); > if (!vec) > return ERR_PTR(-ENOMEM); > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > if (ret < 0) > goto out_destroy; > /* We accept only complete set of PFNs */
For drivers/media/common/videobuf2/: Acked-by: Tomasz Figa <[email protected]> Best regards, Tomasz _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
