Hi Jason, Thank you for the patch.
On Sat, Sep 12, 2020 at 11:38:17AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:217:15: warning: symbol > 'vint_table' was not declared. Should it be static? > > Reported-by: Hulk Robot <[email protected]> > Signed-off-by: Jason Yan <[email protected]> > --- > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > index 1d1c79a18613..b3f5797c23e0 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > @@ -214,7 +214,7 @@ static const u8 > gamma_tbl[S6E3HA2_NUM_GAMMA_STEPS][S6E3HA2_GAMMA_CMD_CNT] = { > 0x00, 0x00 } > }; > > -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { > +static unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { Shouldn't it be const, while at it ? > 0x18, 0x19, 0x1a, 0x1b, 0x1c, > 0x1d, 0x1e, 0x1f, 0x20, 0x21 > }; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
