Hi Lee. On Tue, Jul 21, 2020 at 08:39:19AM +0100, Lee Jones wrote: > Fixes the following kernel build warning: > > drivers/video/backlight/cr_bllcd.c: In function ‘cr_backlight_set_intensity’: > drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable > ‘intensity’ [-Wunused-variable] > 62 | int intensity = bd->props.brightness; > | ^~~~~~~~~ > > Cc: Sam Ravnborg <[email protected]> > Cc: Daniel Thompson <[email protected]> > Cc: Jingoo Han <[email protected]> > Cc: Bartlomiej Zolnierkiewicz <[email protected]> > Cc: [email protected] > Cc: [email protected] > Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight > semantics") > Signed-off-by: Lee Jones <[email protected]>
Thanks for fixing this. The driver only build for X86 so the warnings was lost in other build noise. One more thing to improve before next submission - sorry for this. Reviewed-by: Sam Ravnborg <[email protected]> > --- > drivers/video/backlight/cr_bllcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/backlight/cr_bllcd.c > b/drivers/video/backlight/cr_bllcd.c > index a24d42e1ea3cd..4ad0a72531fe2 100644 > --- a/drivers/video/backlight/cr_bllcd.c > +++ b/drivers/video/backlight/cr_bllcd.c > @@ -59,7 +59,6 @@ struct cr_panel { > > static int cr_backlight_set_intensity(struct backlight_device *bd) > { > - int intensity = bd->props.brightness; > u32 addr = gpio_bar + CRVML_PANEL_PORT; > u32 cur = inl(addr); > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
