The clkdev lookup created for the cpufreq device is never removed if
there's an issue later in probe or at module removal time.

Let's convert to the managed variant of the clk_hw_register_clkdev function
to make sure it happens.

Cc: Michael Turquette <[email protected]>
Cc: [email protected]
Acked-by: Nicolas Saenz Julienne <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
---
 drivers/clk/bcm/clk-raspberrypi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c 
b/drivers/clk/bcm/clk-raspberrypi.c
index 013706816895..eb5c4f5720e8 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -245,8 +245,9 @@ static int raspberrypi_register_pllb_arm(struct 
raspberrypi_clk *rpi)
                return ret;
        }
 
-       ret = clk_hw_register_clkdev(&raspberrypi_clk_pllb_arm.hw,
-                                    NULL, "cpu0");
+       ret = devm_clk_hw_register_clkdev(rpi->dev,
+                                         &raspberrypi_clk_pllb_arm.hw,
+                                         NULL, "cpu0");
        if (ret) {
                dev_err(rpi->dev, "Failed to initialize clkdev\n");
                return ret;
-- 
git-series 0.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to