Hi Ville. On Thu, Apr 02, 2020 at 04:13:10PM +0300, Ville Syrjälä wrote: > On Tue, Mar 03, 2020 at 01:52:27PM +0100, Heiko Stuebner wrote: > > Hi, > > > > Am Montag, 2. März 2020, 21:34:24 CET schrieb Ville Syrjala: > > > From: Ville Syrjälä <[email protected]> > > > > > > The currently listed dotclock disagrees with the currently > > > listed vrefresh rate. Change the dotclock to match the vrefresh. > > > > > > Someone tell me which (if either) of the dotclock or vreresh is > > > correct? > > > > The values came that way from the vendor . > > And lookin at other Leadtek display datasheets, 60Hz should be the > > correct refresh rate. > > > > The display is also running happily at the 69MHz of > > your patch, so > > > > Tested-by: Heiko Stuebner <[email protected]> > > Thanks for confirming. > > I think this patch the last one with a huge difference between > vrefresh and clock. So once this goes in I'm thinking of declaring > the remaining patches as not important and pushing ahead with the > mode dieting. Can someone ack this so I can get it in?
You have done a very good job following up on the individual panels and the above seems like a good plan moving forward. So for the remaining patches: Acked-by: Sam Ravnborg <[email protected]> Sam > > > Heiko > > > > > > > > Cc: Heiko Stuebner <[email protected]> > > > Cc: Sam Ravnborg <[email protected]> > > > Signed-off-by: Ville Syrjälä <[email protected]> > > > --- > > > drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > > > b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > > > index 76ecf2de9c44..113ab9c0396b 100644 > > > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > > > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > > > @@ -377,7 +377,7 @@ static const struct drm_display_mode default_mode = { > > > .vsync_end = 1280 + 30 + 4, > > > .vtotal = 1280 + 30 + 4 + 12, > > > .vrefresh = 60, > > > - .clock = 41600, > > > + .clock = 69217, > > > .width_mm = 62, > > > .height_mm = 110, > > > }; > > > > > > > > > > > -- > Ville Syrjälä > Intel > _______________________________________________ > dri-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
