On Mon, Mar 02, 2020 at 11:25:55PM +0100, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Reviewed-by: Noralf Trønnes <[email protected]> > Signed-off-by: Daniel Vetter <[email protected]> > Cc: "Noralf Trønnes" <[email protected]>
Acked-by: Sam Ravnborg <[email protected]> > --- > drivers/gpu/drm/tiny/repaper.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c > index f5ebcaf7ee3a..df5654ef53ee 100644 > --- a/drivers/gpu/drm/tiny/repaper.c > +++ b/drivers/gpu/drm/tiny/repaper.c > @@ -31,6 +31,7 @@ > #include <drm/drm_format_helper.h> > #include <drm/drm_gem_cma_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > +#include <drm/drm_managed.h> > #include <drm/drm_modes.h> > #include <drm/drm_rect.h> > #include <drm/drm_probe_helper.h> > @@ -910,13 +911,10 @@ static const struct drm_mode_config_funcs > repaper_mode_config_funcs = { > > static void repaper_release(struct drm_device *drm) > { > - struct repaper_epd *epd = drm_to_epd(drm); > - > DRM_DEBUG_DRIVER("\n"); > > drm_mode_config_cleanup(drm); > drm_dev_fini(drm); > - kfree(epd); > } > > static const uint32_t repaper_formats[] = { > @@ -1024,6 +1022,7 @@ static int repaper_probe(struct spi_device *spi) > kfree(epd); > return ret; > } > + drmm_add_final_kfree(drm, epd); > > drm_mode_config_init(drm); > drm->mode_config.funcs = &repaper_mode_config_funcs; > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
