Hi Daniel, Thank you for the patch.
On Wed, Feb 19, 2020 at 11:20:37AM +0100, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > v2: We need drm_dev_put to unroll the driver creation (once > drm_dev_init and drmm_add_final_kfree suceeded), otherwise > the drmm_ magic doesn't happen. > > Signed-off-by: Daniel Vetter <[email protected]> Did you mean to squash this with the previous commit ? > Cc: Dave Airlie <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: Emil Velikov <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: "Noralf Trønnes" <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Sam Ravnborg <[email protected]> > --- > drivers/gpu/drm/udl/udl_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c > index d5b89711ab1e..6a5594946096 100644 > --- a/drivers/gpu/drm/udl/udl_drv.c > +++ b/drivers/gpu/drm/udl/udl_drv.c > @@ -81,8 +81,7 @@ static struct udl_device *udl_driver_create(struct > usb_interface *interface) > > r = udl_init(udl); > if (r) { > - drm_dev_fini(&udl->drm); > - kfree(udl); > + drm_dev_put(&udl->drm); > return ERR_PTR(r); > } > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
