Hi Juston, On Thu, 23 Jan 2020 at 00:37, Juston Li <[email protected]> wrote: > +drm_public void drmModeFreeFB2(drmModeFB2Ptr ptr) > +{ > + if (!ptr) > + return; > + > + /* we might add more frees later. */ > + drmFree(ptr);
I do not recognise this comment, and since free(NULL) is defined to be safe, this entire function can be defined as drmFree(ptr) without the comment or early return. I would like this to be changed before merging. After the revision, this patch is: Signed-off-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
