On Fri, Dec 13, 2019 at 06:26:04PM +0100, Daniel Vetter wrote: > Checking both is one too much, so wrap a WARN_ON around it to stope > the copypasta. > > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Liviu Dudau <[email protected]>
Acked-by: Liviu Dudau <[email protected]> Best regards, Liviu > Cc: Brian Starkey <[email protected]> > Cc: > --- > drivers/gpu/drm/arm/malidp_planes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c > b/drivers/gpu/drm/arm/malidp_planes.c > index 3c70a53813bf..37715cc6064e 100644 > --- a/drivers/gpu/drm/arm/malidp_planes.c > +++ b/drivers/gpu/drm/arm/malidp_planes.c > @@ -512,7 +512,7 @@ static int malidp_de_plane_check(struct drm_plane *plane, > int i, ret; > unsigned int block_w, block_h; > > - if (!state->crtc || !state->fb) > + if (!state->crtc || WARN_ON(!state->fb)) > return 0; > > fb = state->fb; > -- > 2.24.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
