Hi Geert, On Mon, Aug 26, 2019 at 09:31:02AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:51 PM Jacopo Mondi <[email protected]> > wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > > to perform image enhancement and color correction. > > > > Add support for CMM through a driver that supports configuration of > > the 1-dimensional LUT table. More advanced CMM feature will be > > implemented on top of this basic one. > > > > Signed-off-by: Jacopo Mondi <[email protected]> > > Thanks for your patch! > > > --- /dev/null > > +++ b/drivers/gpu/drm/rcar-du/rcar_cmm.c > > > +static const struct of_device_id rcar_cmm_of_table[] = { > > + { .compatible = "renesas,cmm-r8a7795", }, > > + { .compatible = "renesas,cmm-r8a7796", }, > > + { .compatible = "renesas,cmm-r8a77965", }, > > + { .compatible = "renesas,cmm-r8a77990", }, > > + { .compatible = "renesas,cmm-r8a77995", }, > > + { .compatible = "renesas,rcar-gen3-cmm", }, > > As they're all handled the same, you can drop the SoC-specific values > from the driver's match table. > > > + { .compatible = "renesas,rcar-gen2-cmm", }, > > Just wondering: has this been tested on R-Car Gen2? >
Not from me :(
It might not be the smartest move to add a compatible for an un-tested
chip generation. I dragged the gen2 compatible in along the series as
it was there in the downstream driver and I assumed BSP has been
tested there, but since I've not been able to run any test on Gen2
board I should probably drop it? Any volunteer with a Gen2 board that
want to run a test?
Thanks
j
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
