On Mon, 27 May 2019 at 09:19, Emil Velikov <[email protected]> wrote: > > From: Emil Velikov <[email protected]> > > The authentication can be circumvented, by design, by using the render > node. > > From the driver POV there is no distinction between primary and render > nodes, thus we can drop the token. > > Cc: Rob Clark <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: [email protected] > Cc: David Airlie <[email protected]> > Cc: Daniel Vetter <[email protected]> > Signed-off-by: Emil Velikov <[email protected]> > --- > drivers/gpu/drm/msm/msm_drv.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 31deb87abfc6..ac1c7a8a85d0 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -983,17 +983,17 @@ static int msm_ioctl_submitqueue_close(struct > drm_device *dev, void *data, > } > > static const struct drm_ioctl_desc msm_ioctls[] = { > - DRM_IOCTL_DEF_DRV(MSM_GET_PARAM, msm_ioctl_get_param, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_NEW, msm_ioctl_gem_new, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_INFO, msm_ioctl_gem_info, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_PREP, msm_ioctl_gem_cpu_prep, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_FINI, msm_ioctl_gem_cpu_fini, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_SUBMIT, msm_ioctl_gem_submit, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_WAIT_FENCE, msm_ioctl_wait_fence, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_GEM_MADVISE, msm_ioctl_gem_madvise, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_NEW, msm_ioctl_submitqueue_new, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_CLOSE, msm_ioctl_submitqueue_close, > DRM_AUTH|DRM_RENDER_ALLOW), > - DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, > DRM_AUTH|DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GET_PARAM, msm_ioctl_get_param, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_NEW, msm_ioctl_gem_new, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_INFO, msm_ioctl_gem_info, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_PREP, msm_ioctl_gem_cpu_prep, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_FINI, msm_ioctl_gem_cpu_fini, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_SUBMIT, msm_ioctl_gem_submit, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_WAIT_FENCE, msm_ioctl_wait_fence, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_GEM_MADVISE, msm_ioctl_gem_madvise, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_NEW, msm_ioctl_submitqueue_new, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_CLOSE, msm_ioctl_submitqueue_close, > DRM_RENDER_ALLOW), > + DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, > DRM_RENDER_ALLOW), > }; > > static const struct vm_operations_struct vm_ops = { > --
Humble poke? Thanks Emil _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
