On 01.07.2019 11:23, Andrzej Hajda wrote: > On 01.07.2019 05:39, Randy Dunlap wrote: >> From: Randy Dunlap <[email protected]> >> >> A single driver should not enable (select) an entire subsystem, >> such as INPUT, so change the 'select' to "depends on". >> >> Fixes: d6abe6df706c ("drm/bridge: sil_sii8620: do not have a dependency of >> RC_CORE") >> >> Signed-off-by: Randy Dunlap <[email protected]> >> Cc: Inki Dae <[email protected]> >> Cc: Andrzej Hajda <[email protected]> >> Cc: Laurent Pinchart <[email protected]> >> Cc: [email protected] >> --- >> Linus has written this a couple of times in the last 15 years or so, >> but my search fu cannot find it. And there are a few drivers in the >> kernel tree that do this, but we shouldn't be adding more that do so. > > The proper solution has been already posted [1], but it has not been > applied yet to input tree? > > Randy are there chances your patchset will appear in ML in near future, > or should I merge your sii8620 patch alone?
Ups, I used wrong surname, I meant Ronald, added him input ML to cc. Regards Andrzej > > > [1]: > https://lore.kernel.org/lkml/[email protected]/ > > > Regards > > Andrzej > > > >> drivers/gpu/drm/bridge/Kconfig | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> --- lnx-52-rc7.orig/drivers/gpu/drm/bridge/Kconfig >> +++ lnx-52-rc7/drivers/gpu/drm/bridge/Kconfig >> @@ -83,10 +83,9 @@ config DRM_PARADE_PS8622 >> >> config DRM_SIL_SII8620 >> tristate "Silicon Image SII8620 HDMI/MHL bridge" >> - depends on OF >> + depends on OF && INPUT >> select DRM_KMS_HELPER >> imply EXTCON >> - select INPUT >> select RC_CORE >> help >> Silicon Image SII8620 HDMI/MHL bridge chip driver. >> >> >> >> _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
