Hi Paul. On Thu, Jun 27, 2019 at 08:21:12PM +0200, Paul Cercueil wrote: > Simplify a bit the probe function by using the newly introduced > devm_platform_ioremap_resource(), instead of having to call > platform_get_resource() followed by devm_ioremap_resource(). > > Signed-off-by: Paul Cercueil <[email protected]> > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c > b/drivers/gpu/drm/ingenic/ingenic-drm.c > index a069579ca749..02c4788ef1c7 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -580,7 +580,6 @@ static int ingenic_drm_probe(struct platform_device *pdev) > struct drm_bridge *bridge; > struct drm_panel *panel; > struct drm_device *drm; > - struct resource *mem; > void __iomem *base; > long parent_rate; > int ret, irq; > @@ -614,8 +613,7 @@ static int ingenic_drm_probe(struct platform_device *pdev) > drm->mode_config.max_height = 600; > drm->mode_config.funcs = &ingenic_drm_mode_config_funcs; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(dev, mem); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) { > dev_err(dev, "Failed to get memory resource"); Consider to include the error code in the error message here. > return PTR_ERR(base);
With the above fixed/considered: Reviewed-by: Sam Ravnborg <[email protected]> _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
