On 6/25/19 4:58 PM, Dariusz Marcinkiewicz wrote:
> Hi again.
> On Tue, Jun 25, 2019 at 4:45 PM Hans Verkuil <[email protected]> wrote:
>>
>> + mutex_lock(&adap->lock);
>> + if (copy_to_user(parg, &adap->conn_info, sizeof(adap->conn_info)))
>> + ret = -EFAULT;
>> + mutex_unlock(&adap->lock);
>> + return ret;
>> +}
> Shouldn't the lock be released before calling copy_to_user? I guess
> you need to make an extra copy of the conn_info, like it is done for
> other ioctls.
There is no reason for doing that, it would just use additional stack
space.
Regards,
Hans
