On 05.06.2019 09:04, Andrey Smirnov wrote: > Replace explicit polling loop with equivalent call to > tc_poll_timeout() for brevity. No functional change intended. > > Signed-off-by: Andrey Smirnov <[email protected]> > Cc: Archit Taneja <[email protected]> > Cc: Andrzej Hajda <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Tomi Valkeinen <[email protected]> > Cc: Andrey Gusakov <[email protected]> > Cc: Philipp Zabel <[email protected]> > Cc: Cory Tusar <[email protected]> > Cc: Chris Healy <[email protected]> > Cc: Lucas Stach <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/gpu/drm/bridge/tc358767.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c > index fb8a1942ec54..5e1e73a91696 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -774,7 +774,6 @@ static int tc_main_link_enable(struct tc_data *tc) > struct device *dev = tc->dev; > unsigned int rate; > u32 dp_phy_ctrl; > - int timeout; > u32 value; > int ret; > u8 tmp[8]; > @@ -831,15 +830,11 @@ static int tc_main_link_enable(struct tc_data *tc) > dp_phy_ctrl &= ~(DP_PHY_RST | PHY_M1_RST | PHY_M0_RST); > tc_write(DP_PHY_CTRL, dp_phy_ctrl); > > - timeout = 1000; > - do { > - tc_read(DP_PHY_CTRL, &value); > - udelay(1); > - } while ((!(value & PHY_RDY)) && (--timeout)); > - > - if (timeout == 0) { > - dev_err(dev, "timeout waiting for phy become ready"); > - return -ETIMEDOUT; > + ret = tc_poll_timeout(tc, DP_PHY_CTRL, PHY_RDY, PHY_RDY, 1, 1000); > + if (ret) { > + if (ret == -ETIMEDOUT) > + dev_err(dev, "timeout waiting for phy become ready"); > + return ret;
Reviewed-by: Andrzej Hajda <[email protected]> -- Regards Andrzej > } > > /* Set misc: 8 bits per color */
