On Thu, May 23, 2019 at 02:13:20PM +0800, CK Hu wrote: > Hi, Sean: > > On Wed, 2019-05-22 at 16:21 -0400, Sean Paul wrote: > > From: Sean Paul <[email protected]> > > > > Fixes the following build warning: > > drivers/gpu/drm/mediatek/mtk_hdmi.c:327:2: warning: enumeration value > > ‘HDMI_INFOFRAME_TYPE_DRM’ not handled in switch [-Wswitch] > > > > Introduced with the addition of HDMI_INFOFRAME_TYPE_DRM in the commit > > below, but the code really should have been future-proofed from the > > start. > > Acked-by: CK Hu <[email protected]> > > > > > Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support") > > I think "drm: Enable HDR infoframe support" exist only in drm-misc tree, > could you just merge this patch to "drm: Enable HDR infoframe support"?
Yes, I've applied it to drm-misc-next. Thanks for your Ack! Sean > > Regards, > CK > > > Cc: Uma Shankar <[email protected]> > > Cc: Shashank Sharma <[email protected]> > > Cc: Ville Syrjälä <[email protected]> > > Cc: Maarten Lankhorst <[email protected]> > > Cc: Maxime Ripard <[email protected]> > > Cc: Sean Paul <[email protected]> > > Cc: David Airlie <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Bartlomiej Zolnierkiewicz <[email protected]> > > Cc: "Ville Syrjälä" <[email protected]> > > Cc: Hans Verkuil <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Sean Paul <[email protected]> > > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > index e04e6c293d39..10cc9910f164 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > @@ -341,6 +341,9 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi > > *hdmi, u8 *buffer, > > ctrl_frame_en = VS_EN; > > ctrl_reg = GRL_ACP_ISRC_CTRL; > > break; > > + default: > > + dev_err(hdmi->dev, "Unknown infoframe type %d\n", frame_type); > > + return; > > } > > mtk_hdmi_clear_bits(hdmi, ctrl_reg, ctrl_frame_en); > > mtk_hdmi_write(hdmi, GRL_INFOFRM_TYPE, frame_type); > > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
