On Mon, May 20, 2019 at 7:08 PM Sam Ravnborg <[email protected]> wrote: > > Hi Daniel. > > While browsing this nice patch series I stumbled upon a detail. > > On Mon, May 20, 2019 at 10:21:53AM +0200, Daniel Vetter wrote: > > With > > > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > > Author: Daniel Vetter <[email protected]> > > Date: Tue Aug 1 17:32:07 2017 +0200 > > > > fbcon: Make fbcon a built-time depency for fbdev > > > > we have a static dependency between fbcon and fbdev, and we can > > replace the indirection through the notifier chain with a function > > call. > > > > Signed-off-by: Daniel Vetter <[email protected]> > > Cc: Bartlomiej Zolnierkiewicz <[email protected]> > > Cc: Daniel Vetter <[email protected]> > > Cc: Hans de Goede <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > Cc: "Noralf Trønnes" <[email protected]> > > Cc: Yisheng Xie <[email protected]> > > Cc: Peter Rosin <[email protected]> > > Cc: "Michał Mirosław" <[email protected]> > > Cc: Thomas Zimmermann <[email protected]> > > Cc: Mikulas Patocka <[email protected]> > > Cc: [email protected] > > --- > > diff --git a/include/linux/fb.h b/include/linux/fb.h > > index f52ef0ad6781..701abaf79c87 100644 > > --- a/include/linux/fb.h > > +++ b/include/linux/fb.h > > @@ -136,10 +136,6 @@ struct fb_cursor_user { > > #define FB_EVENT_RESUME 0x03 > > /* An entry from the modelist was removed */ > > #define FB_EVENT_MODE_DELETE 0x04 > > -/* A driver registered itself */ > > -#define FB_EVENT_FB_REGISTERED 0x05 > > -/* A driver unregistered itself */ > > -#define FB_EVENT_FB_UNREGISTERED 0x06 > > /* CONSOLE-SPECIFIC: get console to framebuffer mapping */ > > #define FB_EVENT_GET_CONSOLE_MAP 0x07 > > /* CONSOLE-SPECIFIC: set console to framebuffer mapping */ > > This breaks build of arch/arm/mach-pxa/am200epd.c thats uses > FB_EVENT_FB_*REGISTERED: > > > if (event == FB_EVENT_FB_REGISTERED) > return am200_share_video_mem(info); > else if (event == FB_EVENT_FB_UNREGISTERED) > return am200_unshare_video_mem(info); > > > Found while grepping for "FB_EVENT" so this is not a build > error I triggered.
Oh this is glorious :-/ Thanks a lot for spotting this, I guess I need to hack around on metronomefb a bit ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
