On Mon, May 20, 2019 at 11:06 AM Geert Uytterhoeven
<[email protected]> wrote:
>
> On Mon, May 20, 2019 at 10:22 AM Daniel Vetter <[email protected]> wrote:
> > This seems to be entirely defunct:
> >
> > - The FB_EVEN_SUSPEND/RESUME events are only sent out by
> > fb_set_suspend. Which is supposed to be called by drivers in their
> > suspend/resume hooks, and not itself call into drivers. Luckily
> > sh_mob doesn't call fb_set_suspend, so this seems to do nothing
> > useful.
> >
> > - The notify hook calls sh_mobile_fb_reconfig() which in turn can
> > call into the fb notifier. Or attempt too, since that would
> > deadlock.
> >
> > So looks like leftover hacks from when this was originally introduced
> > in
> >
> > commit 6011bdeaa6089d49c02de69f05980da7bad314ab
> > Author: Guennadi Liakhovetski <[email protected]>
> > Date: Wed Jul 21 10:13:21 2010 +0000
> >
> > fbdev: sh-mobile: HDMI support for SH-Mobile SoCs
> >
> > So let's just remove it.
> >
> > Signed-off-by: Daniel Vetter <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Display still works fine on Armadillo800-EVA, before and after system
> suspend/resume, so:
>
> Tested-by: Geert Uytterhoeven <[email protected]>
I'm impressed, I honestly think I do not fully understand what the
shmob driver is doing here, so thank you very much for giving this a
spin!
Cheers, Daniel
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
