On Sat, 20 Apr 2019 at 05:25, John Stultz <[email protected]> wrote: > > From: Sean Paul <[email protected]> > > __mmap2 isn't supported on all platforms, mmap64 is the right way > to do this in android. > > Also folds in a fix from Stéphane Marchesin <[email protected]> > to use an offset in bytes not pages, as that's what mmap64 takes. > > Cc: Emil Velikov <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: Alistair Strachan <[email protected]> > Cc: Marissa Wall <[email protected]> > Signed-off-by: Sean Paul <[email protected]> > Signed-off-by: John Stultz <[email protected]> > --- > libdrm_macros.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > From a quick look mmap64 was introduced in bionic with Andoid 5 (Lollipop). A reasonable min. version although we're lacking a check.
As a separate commit, copy the PLATFORM_VERSION hunk (or equiv.) from Mesa's Android.mk. Here I'd add a note "introduced with Android L which we require as of earlier commit" and drop the bytes/pages mention. With that this patch is: Reviewed-by: Emil Velikov <[email protected]> -Emil _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
