Hi, On Tue, Apr 2, 2019 at 4:38 AM Heiko Stuebner <[email protected]> wrote: > > From: Vicente Bergas <[email protected]> > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > > straight out onto the bus as physical addresses. > > We had a more radical approach before in commit > 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec") > but that resulted in new warnings and oopses on shutdown on rk3399 > chromeos devices. > > So second try is resurrecting Vicentes shutdown change which should > achieve the same result but in a less drastic way. > > Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on > reboot/kexec") > Cc: Jeffy Chen <[email protected]> > Cc: Robin Murphy <[email protected]> > Cc: Marc Zyngier <[email protected]> > Cc: Brian Norris <[email protected]> > Cc: Doug Anderson <[email protected]> > Cc: [email protected] > Suggested-by: JeffyChen <[email protected]> > Suggested-by: Robin Murphy <[email protected]> > Signed-off-by: Vicente Bergas <[email protected]> > [adapted commit message to explain the history] > Signed-off-by: Heiko Stuebner <[email protected]> > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 +++++++++ > 1 file changed, 9 insertions(+)
I picked this back to the Chrome OS 4.19 kernel and tried it on rk3288-veyron-jerry. Rebooting caused no complaints (I confirmed this code was running by adding a printk). I plugged in to an HDMI monitor. Rebooting caused no complaints. I then let the display idle off (just in case that mattered). Again no complaints. Thus, in case it's helpful: Tested-by: Douglas Anderson <[email protected]> _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
