On Thu, 28 Feb 2019 15:49:04 +0100 Daniel Vetter <[email protected]> wrote:
> Not exactly sure what's the aim here, but the canonical nil object has > id == 0, we don't use negative object ids for anything. Plus all > object_id are valided by the object_idr, there's nothing we need to do > on top of that ENOENT check a bit further down. > > Spotted while typing exhaustive igt coverage for all these > corner-cases. > > Cc: Keith Packard <[email protected]> > Signed-off-by: Daniel Vetter <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> > --- > drivers/gpu/drm/drm_lease.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c > index 603b0bd9c5ce..1176d814cf7f 100644 > --- a/drivers/gpu/drm/drm_lease.c > +++ b/drivers/gpu/drm/drm_lease.c > @@ -403,11 +403,6 @@ static int fill_object_idr(struct drm_device *dev, > /* step one - get references to all the mode objects > and check for validity. */ > for (o = 0; o < object_count; o++) { > - if ((int) object_ids[o] < 0) { > - ret = -EINVAL; > - goto out_free_objects; > - } > - > objects[o] = drm_mode_object_find(dev, lessor_priv, > object_ids[o], > DRM_MODE_OBJECT_ANY); _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
