On Tue, Feb 26, 2019 at 11:36:04AM -0800, Andrey Smirnov wrote: > Replace explicit polling loop with equivalent call to > regmap_read_poll_timeout() for simplicity. No functional change > intended. > > Signed-off-by: Andrey Smirnov <[email protected]> > Cc: Archit Taneja <[email protected]> > Cc: Andrzej Hajda <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Chris Healy <[email protected]> > Cc: Lucas Stach <[email protected]> > Cc: [email protected] > Cc: [email protected]
Reviewed-by: Laurent Pinchart <[email protected]> > --- > drivers/gpu/drm/bridge/tc358767.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c > index c85468fcc157..6455e6484722 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -882,15 +882,11 @@ static int tc_main_link_setup(struct tc_data *tc) > dp_phy_ctrl &= ~(DP_PHY_RST | PHY_M1_RST | PHY_M0_RST); > tc_write(DP_PHY_CTRL, dp_phy_ctrl); > > - timeout = 1000; > - do { > - tc_read(DP_PHY_CTRL, &value); > - udelay(1); > - } while ((!(value & PHY_RDY)) && (--timeout)); > - > - if (timeout == 0) { > + ret = regmap_read_poll_timeout(tc->regmap, DP_PHY_CTRL, value, > + value & PHY_RDY, 1, 1000); > + if (ret) { > dev_err(dev, "timeout waiting for phy become ready"); > - return -ETIMEDOUT; > + return ret; > } > > /* Set misc: 8 bits per color */ -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
