On Tue, Feb 12, 2019 at 6:56 PM Qiang Yu <[email protected]> wrote:
>
> On Tue, Feb 12, 2019 at 11:47 PM Rob Herring <[email protected]> wrote:
> >
> > On Wed, Feb 6, 2019 at 7:16 AM Qiang Yu <[email protected]> wrote:
> > >
> > > From: Lima Project Developers <[email protected]>
> >
> > This should be a person (you).
> >
> > > Signed-off-by: Andreas Baierl <[email protected]>
> > > Signed-off-by: Erico Nunes <[email protected]>
> > > Signed-off-by: Heiko Stuebner <[email protected]>
> > > Signed-off-by: Marek Vasut <[email protected]>
> > > Signed-off-by: Neil Armstrong <[email protected]>
> > > Signed-off-by: Qiang Yu <[email protected]>
> >
> > Being the submitter, your S-o-b should be last.
> >
> > > Signed-off-by: Simon Shields <[email protected]>
> > > Signed-off-by: Vasily Khoruzhick <[email protected]>
> > > ---

> > > +
> > > +unsigned long lima_timeout_to_jiffies(u64 timeout_ns)
> >
> > Create a common helper instead of copy-n-pasting this from other
> > drivers (etnaviv).
> There's one drm_timeout_abs_to_jiffies but not exported.

Then let's export it. We don't work around kernel APIs or lack of. We fix them.


Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to