On Thu, Nov 29, 2018 at 03:36:48PM -0500, Sean Paul wrote: > From: Sean Paul <[email protected]> > > Kbuild was complaining about: > >> drivers/gpu/drm/drm_atomic_helper.c:3169:27: warning: 'state' may be used > >> uninitialized in this function [-Wmaybe-uninitialized] > > Now state can't actually be used uninitialized, but we'll assign a value > anyways so it stops bellyaching. > > Fixes: b7ea04d299c7 ("drm: Add DRM_MODESET_LOCK_BEGIN/END helpers") > Cc: Daniel Vetter <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: David Airlie <[email protected]> > Cc: [email protected] > Signed-off-by: Sean Paul <[email protected]>
Reviewed-by: Daniel Vetter <[email protected]> > --- > drivers/gpu/drm/drm_atomic_helper.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index 0d58c40aa4401..0ee83efeb94a4 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -3169,6 +3169,9 @@ struct drm_atomic_state > *drm_atomic_helper_suspend(struct drm_device *dev) > struct drm_atomic_state *state; > int err; > > + /* This can never be returned, but it makes the compiler happy */ > + state = ERR_PTR(-EINVAL); > + > DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, err); > > state = drm_atomic_helper_duplicate_state(dev, &ctx); > -- > Sean Paul, Software Engineer, Google / Chromium OS > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
