On 29.10.2018 12:47, Tomi Valkeinen wrote: > The H and V syncs of the DP output are always set to active high. This > patch fixes the syncs by configuring them according to the videomode. > > Signed-off-by: Tomi Valkeinen <[email protected]> > --- > drivers/gpu/drm/bridge/tc358767.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c > index b026b5ef7378..be013bd7b30b 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -726,7 +726,9 @@ static int tc_set_video_mode(struct tc_data *tc, struct > drm_display_mode *mode) > > tc_write(DP0_ACTIVEVAL, (mode->vdisplay << 16) | (mode->hdisplay)); > > - tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0)); > + tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0) | > + ((mode->flags & DRM_MODE_FLAG_NHSYNC) ? (1 << 15) : 0) | > + ((mode->flags & DRM_MODE_FLAG_NVSYNC) ? (1 << 31) : 0));
Defines for sync flags would be better. Anyway: Reviewed-by: Andrzej Hajda <[email protected]> -- Regards Andrzej > > tc_write(DPIPXLFMT, VS_POL_ACTIVE_LOW | HS_POL_ACTIVE_LOW | > DE_POL_ACTIVE_HIGH | SUB_CFG_TYPE_CONFIG1 | DPI_BPP_RGB888); _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
