On 2018/11/15 19:49, Huang, Ray wrote: >> -----Original Message----- >> From: YueHaibing [mailto:[email protected]] >> Sent: Thursday, November 15, 2018 6:52 PM >> To: Deucher, Alexander <[email protected]>; Koenig, Christian >> <[email protected]>; Zhou, David(ChunMing) >> <[email protected]>; [email protected]; Liu, Shaoyun >> <[email protected]>; Francis, David <[email protected]>; Huang, >> Ray <[email protected]>; Xu, Feifei <[email protected]>; Gao, Likun >> <[email protected]> >> Cc: YueHaibing <[email protected]>; [email protected]; >> [email protected]; [email protected]; kernel- >> [email protected] >> Subject: [PATCH -next] drm/amdgpu: remove set but not used variable 'ring' >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c: In function >> 'psp_v10_0_ring_stop': >> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c:230:19: warning: >> variable 'ring' set but not used [-Wunused-but-set-variable] >> >> It not used since commit >> 4ef72453311a ("drm/amdgpu: added api for stopping psp ring (v2)") > > Thanks, please also remove the similar code in psp_v3_1. > With that updates, patch is Reviewed-by: Huang Rui <[email protected]> >
Ok, will send v2. >> >> Signed-off-by: YueHaibing <[email protected]> >> --- >> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c >> b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c >> index 295c220..d78b430 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c >> @@ -240,12 +240,9 @@ static int psp_v10_0_ring_stop(struct psp_context >> *psp, >> enum psp_ring_type ring_type) { >> int ret = 0; >> - struct psp_ring *ring; >> unsigned int psp_ring_reg = 0; >> struct amdgpu_device *adev = psp->adev; >> >> - ring = &psp->km_ring; >> - >> /* Write the ring destroy command to C2PMSG_64 */ >> psp_ring_reg = 3 << 16; >> WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64, psp_ring_reg); >> >> >> >> > > > . > _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
