Quoting Chunming Zhou (2018-10-25 16:08:31) > drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function > drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line > 389 but uses GFP_KERNEL > > Find functions that refer to GFP_KERNEL but are called with locks held. > > Generated by: scripts/coccinelle/locks/call_kern.cocci > > v2: > syncobj->timeline still needs protect. > > v3: > use a global signaled fence instead of re-allocation. > > v4: > Don't need moving lock. > Don't expose func. > > Tested by: syncobj_wait and ./deqp-vk -n dEQP-VK.*semaphore* with > lock debug kernel options enabled. > > Signed-off-by: Chunming Zhou <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: [email protected] > Cc: Christian König <[email protected]> > Cc: Chris Wilson <[email protected]> > CC: Julia Lawall <[email protected]> > --- > - return NULL; > +out: > + return f;
As it reduced to just a return, I'd probably have gone with multiple returns in this instance. Still the compiler should have done the equivalent and jumped to a single ret. Reviewed-by: Chris Wilson <[email protected]> -Chris _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
