On Tue, Oct 02, 2018 at 06:34:39PM +0300, Ville Syrjälä wrote: > On Tue, Oct 02, 2018 at 03:35:16PM +0200, Daniel Vetter wrote: > > These do absolutely nothing for atomic drivers. > > > > Signed-off-by: Daniel Vetter <[email protected]> > > Cc: Alexey Brodkin <[email protected]> > > --- > > drivers/gpu/drm/arc/arcpgu_crtc.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c > > b/drivers/gpu/drm/arc/arcpgu_crtc.c > > index 965cda48dc13..26cb2800f3ad 100644 > > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > > @@ -158,8 +158,6 @@ static void arc_pgu_crtc_atomic_begin(struct drm_crtc > > *crtc, > > > > static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { > > .mode_valid = arc_pgu_crtc_mode_valid, > > - .mode_set = drm_helper_crtc_mode_set, > > - .mode_set_base = drm_helper_crtc_mode_set_base, > > .mode_set_nofb = arc_pgu_crtc_mode_set_nofb, > > .atomic_begin = arc_pgu_crtc_atomic_begin, > > .atomic_enable = arc_pgu_crtc_atomic_enable, > > It's easy to get confused with all the hooks and helpers. But after > staring at the code a bit this looks correct to me:
Hm, I guess I could write a patch that liberally sprinkles WARN_ON on all the deprecated hooks if you're an atomic driver. But that's kinda for another time. > Reviewed-by: Ville Syrjälä <[email protected]> > > > -- > > 2.19.0.rc2 > > > > _______________________________________________ > > Intel-gfx mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
