Thank you, Andrzej! I was a bit afraid that our patches are a bit too messy and thus ignored 😊 Anyway, this patch (1/5) should be the last one that will cause such chaos in the DRM area.
Regards, Damian -----Original Message----- From: Andrzej Hajda <[email protected]> Sent: Thursday, September 13, 2018 12:01 To: Damian Kos <[email protected]>; David Airlie <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Archit Taneja <[email protected]>; Laurent Pinchart <[email protected]>; Gustavo Padovan <[email protected]>; Maarten Lankhorst <[email protected]>; Sean Paul <[email protected]>; Sandy Huang <[email protected]>; Heiko Stübner <[email protected]>; Quentin Schulz <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Cc: Przemyslaw Gaj <[email protected]>; Lukasz Tyrala <[email protected]>; Scott Telford <[email protected]>; Artur Jedrysek <[email protected]>; Piotr Sroka <[email protected]> Subject: Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver EXTERNAL MAIL Hi Damian, Quite late but. On 28.08.2018 12:24, Damian Kos wrote: > - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device > structure which will be used by two separate drivers later on. > - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format, > video_info) from cdn-dp-core.c to cdn-dp-reg.h. > - Changed prefixes from cdn_dp to cdns_mhdp > cdn -> cdns to match the other Cadence's drivers > dp -> mhdp to distinguish it from a "just a DP" as the IP underneath > this registers map can be a HDMI (which is internally different, > but the interface for commands, events is pretty much the same). > - Modified cdn-dp-core.c to use the new driver structure and new function > names. > > Signed-off-by: Damian Kos <[email protected]> Many changes, hard to review. Anyway: Reviewed-by: Andrzej Hajda <[email protected]>  -- Regards Andrzej _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
