Hi Daniel, On 4 July 2018 at 10:29, Daniel Vetter <[email protected]> wrote: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > v2: Also remove the relase hook, dma_fence_free is the default. > > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Cc: Rodrigo Vivi <[email protected]> > Cc: Chris Wilson <[email protected]> > Cc: Tvrtko Ursulin <[email protected]> > Cc: Colin Ian King <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Mika Kuoppala <[email protected]> > Cc: [email protected] > --- > drivers/gpu/drm/i915/i915_gem_clflush.c | 7 ------- > drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 8 -------- > 2 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_clflush.c > b/drivers/gpu/drm/i915/i915_gem_clflush.c > index f5c570d35b2a..8e74c23cbd91 100644 > --- a/drivers/gpu/drm/i915/i915_gem_clflush.c > +++ b/drivers/gpu/drm/i915/i915_gem_clflush.c > @@ -45,11 +45,6 @@ static const char *i915_clflush_get_timeline_name(struct > dma_fence *fence) > return "clflush"; > } > > -static bool i915_clflush_enable_signaling(struct dma_fence *fence) > -{ > - return true; > -} > - > static void i915_clflush_release(struct dma_fence *fence) > { > struct clflush *clflush = container_of(fence, typeof(*clflush), dma); > @@ -63,8 +58,6 @@ static void i915_clflush_release(struct dma_fence *fence) > static const struct dma_fence_ops i915_clflush_ops = { > .get_driver_name = i915_clflush_get_driver_name, > .get_timeline_name = i915_clflush_get_timeline_name, > - .enable_signaling = i915_clflush_enable_signaling, From a quick look through drm-misc/drm-misc-next removing the enable_signalling hook may cause functional changes.
Namely: A call to trace_dma_fence_enable_signal() (in dma_fence_enable_sw_signaling(), dma_fence_add_callback() and others) will be omitted. Removing the default .wait and .release hooks is fine. HTH Emil _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
