Hi Jacopo, On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > output converter. > > Signed-off-by: Jacopo Mondi <[email protected]> > Reviewed-by: Andrzej Hajda <[email protected]> > Reviewed-by: Niklas Söderlund <[email protected]>
Reviewed-by: Vladimir Zapolskiy <[email protected]> Generally I have only one pretty ignorable comment. > + > +enum thc63_ports { > + THC63_LVDS_IN0, > + THC63_LVDS_IN1, > + THC63_RGB_OUT0, > + THC63_RGB_OUT1, > +}; > + The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC configuration is ignored. I don't know if right from the beginning it would be better to support dual-out modes, preferably both single-in and dual-in ones. Will it impact port enumeration? I do understand that the extension is possible, and likely only hardware accessibility postpones it. -- With best wishes, Vladimir _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
