This makes sense once we got rid of plane->fb Will this go to drm-next? Could you please CC me so that I can do some testing myself. Thanks.
Reviewed-by: Deepak Rawat <[email protected]> > > From: Ville Syrjälä <[email protected]> > > We want to get rid of plane->fb on atomic drivers. Stop setting it. > > Cc: Thomas Hellstrom <[email protected]> > Cc: Sinclair Yeh <[email protected]> > Cc: VMware Graphics <[email protected]> > Cc: Daniel Vetter <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 -- > drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > index 648f8127f65a..bbd3f19b1a0b 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c > @@ -525,8 +525,6 @@ vmw_sou_primary_plane_atomic_update(struct > drm_plane *plane, > */ > if (ret != 0) > DRM_ERROR("Failed to update screen.\n"); > - > - crtc->primary->fb = plane->state->fb; > } else { > /* > * When disabling a plane, CRTC and FB should always be > NULL > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c > index 67331f01ef32..90445bc590cb 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c > @@ -1285,8 +1285,6 @@ vmw_stdu_primary_plane_atomic_update(struct > drm_plane *plane, > 1, 1, NULL, crtc); > if (ret) > DRM_ERROR("Failed to update STDU.\n"); > - > - crtc->primary->fb = plane->state->fb; > } else { > crtc = old_state->crtc; > stdu = vmw_crtc_to_stdu(crtc); > -- > 2.16.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
