This looks okay to me. Reviewed-by: Sinclair Yeh <[email protected]>
On Thu, Nov 23, 2017 at 09:05:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <[email protected]> > > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. > > Note that this replaces crtc_state->adjusted_mode usage with > crtc_state->mode. The latter is the correct choice since that's the > mode the user provided and it matches the plane crtc coordinates > the user also provided. > > Once everyone agrees on this we can move the clip handling into > drm_atomic_helper_check_plane_state(). > > Cc: Laurent Pinchart <[email protected]> > Cc: VMware Graphics <[email protected]> > Cc: Sinclair Yeh <[email protected]> > Cc: Thomas Hellstrom <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index a2a93d7e2a04..25d96560180b 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -449,10 +449,9 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane > *plane, > if (state->crtc) > crtc_state = drm_atomic_get_new_crtc_state(state->state, > state->crtc); > > - if (crtc_state && crtc_state->enable) { > - clip.x2 = crtc_state->adjusted_mode.hdisplay; > - clip.y2 = crtc_state->adjusted_mode.vdisplay; > - } > + if (crtc_state && crtc_state->enable) > + drm_mode_get_hv_timing(&crtc_state->mode, > + &clip.x2, &clip.y2); > > ret = drm_atomic_helper_check_plane_state(state, crtc_state, &clip, > DRM_PLANE_HELPER_NO_SCALING, > -- > 2.13.6 > _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
