drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]

[David Binderman]

Hello there,

Source code is

        if ((temp & PIPEACONF_PIPE_STATE) == 1)
            break;

but

$ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE             
(1 << 30)
$ 

Suggest new code

        if ((temp & PIPEACONF_PIPE_STATE) != 0)
            break;

Regards

David Binderman
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel