On Wed, Sep 13, 2017 at 4:16 PM, Julia Lawall <[email protected]> wrote: > > > On Wed, 13 Sep 2017, Meghana Madhyastha wrote: > >> EXPORT_SYMBOL(foo) should immediately follow its function/variable. >> This coding style is preferred. >> Found by checkpath.pl. >> >> Signed-off-by: Meghana Madhyastha <[email protected]>
With Julia's suggestion resolved: Reviewed-by: Sean Paul <[email protected]> >> --- >> drivers/gpu/drm/drm_agpsupport.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_agpsupport.c >> b/drivers/gpu/drm/drm_agpsupport.c >> index c899534..928248e 100644 >> --- a/drivers/gpu/drm/drm_agpsupport.c >> +++ b/drivers/gpu/drm/drm_agpsupport.c >> @@ -70,7 +70,6 @@ int drm_agp_info(struct drm_device *dev, struct >> drm_agp_info *info) >> >> return 0; >> } >> - >> EXPORT_SYMBOL(drm_agp_info); >> >> int drm_agp_info_ioctl(struct drm_device *dev, void *data, >> @@ -106,7 +105,6 @@ int drm_agp_acquire(struct drm_device * dev) >> dev->agp->acquired = 1; >> return 0; >> } >> - >> EXPORT_SYMBOL(drm_agp_acquire); >> >> /** >> @@ -171,7 +169,6 @@ int drm_agp_enable(struct drm_device * dev, struct >> drm_agp_mode mode) >> dev->agp->enabled = 1; >> return 0; >> } >> - >> EXPORT_SYMBOL(drm_agp_enable); >> >> int drm_agp_enable_ioctl(struct drm_device *dev, void *data, >> @@ -373,7 +370,6 @@ int drm_agp_free(struct drm_device *dev, struct >> drm_agp_buffer *request) >> EXPORT_SYMBOL(drm_agp_free); >> >> >> - > > I still don't think this change belongs in this patch. I ran checkpatch > on this file, and I only get warnings about the first three > EXPORT_SYMBOLs. There is no warning related to EXPORT_SYMBOL after line > 175. > > julia > >> int drm_agp_free_ioctl(struct drm_device *dev, void *data, >> struct drm_file *file_priv) >> { >> -- >> 2.7.4 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/outreachy-kernel/20170913161340.GA3204%40meghana-HP-Pavilion-Notebook. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1709132214330.2920%40hadrien. > For more options, visit https://groups.google.com/d/optout. _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
