On Wed, Jun 28, 2017 at 12:16:17AM +0300, Laurent Pinchart wrote:
> The CRTC helper .commit() operation is legacy code, the atomic helpers
> prefer the .enable() operation. Replace the .commit() helper operation
> with .enable() in the driver.
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> ---
> drivers/gpu/drm/qxl/qxl_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c
> b/drivers/gpu/drm/qxl/qxl_display.c
> index 19ba336ce096..7ede5f131a5c 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -447,7 +447,7 @@ static void qxl_mode_set_nofb(struct drm_crtc *crtc)
>
> }
>
> -static void qxl_crtc_commit(struct drm_crtc *crtc)
> +static void qxl_crtc_enable(struct drm_crtc *crtc)
> {
> DRM_DEBUG("\n");
> }
Same comment as for vmwgfx: Would be even better to just nuke the dummy
func here.
-Daniel
> @@ -466,7 +466,7 @@ static const struct drm_crtc_helper_funcs
> qxl_crtc_helper_funcs = {
> .disable = qxl_crtc_disable,
> .mode_fixup = qxl_crtc_mode_fixup,
> .mode_set_nofb = qxl_mode_set_nofb,
> - .commit = qxl_crtc_commit,
> + .enable = qxl_crtc_enable,
> .atomic_flush = qxl_crtc_atomic_flush,
> };
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
