On 15.05.2017 11:33, Daniel Vetter wrote: > From: Jose Abreu <[email protected]> > > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has some sort of restriction in the modes > that can be displayed. A NULL callback implicates that the component > can display all the modes. > > We also change the documentation so that the new and old callbacks > are correctly documented. > > Only the callbacks were implemented to simplify review process, > following patches will make use of them. > > Changes in v2 from Daniel: > - Update the warning about how modes aren't filtered in atomic_check - > the heleprs help out a lot more now. > - Consistenly roll out that warning, crtc/encoder's atomic_check > missed it. > - Sprinkle more links all over the place, so it's easier to see where > this stuff is used and how the differen hooks are related. > - Note that ->mode_valid is optional everywhere. > - Explain why the connector's mode_valid is special and does _not_ get > called in atomic_check. > > v3: Document what can and cannot be checked in mode_valid a bit better > (Andrjez). Answer: Only allowed to look at the mode, nothing else. > > Cc: Laurent Pinchart <[email protected]> > Signed-off-by: Jose Abreu <[email protected]> > Cc: Jose Abreu <[email protected]> > Cc: Carlos Palminha <[email protected]> > Cc: Alexey Brodkin <[email protected]> > Cc: Ville Syrjälä <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Dave Airlie <[email protected]> > Cc: Andrzej Hajda <[email protected]> > Cc: Archit Taneja <[email protected]> > Signed-off-by: Daniel Vetter <[email protected]> (v2) Reviewed-by: Andrzej Hajda <[email protected]>
-- Regards Andrzej _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
