On Thu, Apr 6, 2017 at 2:55 PM, Daniel Vetter <[email protected]> wrote: > Legacy drivers insist that we really take all the locks in this path, > and the harm in doing so is minimal. > > Fixes: 2ceb585a956c ("drm: Add explicit acquire ctx handling around > ->set_config") > Cc: Harry Wentland <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: David Airlie <[email protected]> > Cc: [email protected] > Cc: Alex Deucher <[email protected]> > Reported-by: Alex Deucher <[email protected]> > Signed-off-by: Daniel Vetter <[email protected]>
Acked-and-tested-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/drm_crtc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index d69e180fc563..42257f373c59 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -576,6 +576,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, > } > DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name); > > + mutex_lock(crtc->dev->mode.config.mutex); > drm_modeset_acquire_init(&ctx, 0); > retry: > ret = drm_modeset_lock_all_ctx(crtc->dev, &ctx); > @@ -721,6 +722,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, > } > drm_modeset_drop_locks(&ctx); > drm_modeset_acquire_fini(&ctx); > + mutex_unlock(crtc->dev->mode.config.mutex); > > return ret; > } > -- > 2.11.0 > _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
