On 10.03.2017 05:32, Sean Paul wrote: > From: Douglas Anderson <[email protected]> > > The current user of the analogix power_off is "analogix_dp-rockchip". > That driver does this: > - deactivate PSR > - turn off a clock > > Both of these things (especially deactive PSR) should be done before > we turn the PHY power off and turn off analog power. Let's move the > callback up. > > Note that without this patch (and with > https://patchwork.kernel.org/patch/9553349/ > [seanpaul: this patch was not applied, but it seems like the race > can still occur]), I experienced an error in reboot testing where one > thread was at: > > rockchip_drm_psr_deactivate > rockchip_dp_powerdown > analogix_dp_bridge_disable > drm_bridge_disable > > ...and the other thread was at: > > analogix_dp_send_psr_spd > analogix_dp_enable_psr > analogix_dp_psr_set > psr_flush_handler > > The flush handler thread was finding AUX channel errors and eventually > reported "Failed to apply PSR", where I had a kgdb breakpoint. Presumably > the device would have eventually given up and shut down anyway, but it > seems better to fix the order to be more correct. > > Cc: Kristian H. Kristensen <[email protected]> > Signed-off-by: Douglas Anderson <[email protected]> > Signed-off-by: Sean Paul <[email protected]>
Reviewed-by: Andrzej Hajda <[email protected]> -- Regards Andrzej _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
