Hi Shawn, Thank you for the patch.
On Tuesday 07 Feb 2017 17:16:14 Shawn Guo wrote: > From: Shawn Guo <[email protected]> > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So the drm_vblank_no_hw_counter assignment in the driver > code becomes redundant and can be removed now. > > Signed-off-by: Shawn Guo <[email protected]> > Cc: Alexey Brodkin <[email protected]> > Cc: Liviu Dudau <[email protected]> > Cc: Mali DP Maintainers <[email protected]> > Cc: Russell King <[email protected]> > Cc: Boris Brezillon <[email protected]> > Cc: Inki Dae <[email protected]> > Cc: Stefan Agner <[email protected]> > Cc: Xinliang Liu <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Philipp Zabel <[email protected]> > Cc: CK Hu <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Rob Clark <[email protected]> > Cc: Marek Vasut <[email protected]> > Cc: Ben Skeggs <[email protected]> > Cc: Tomi Valkeinen <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Mark Yao <[email protected]> > Cc: Benjamin Gaignard <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Jyri Sarha <[email protected]> > Cc: Eric Anholt <[email protected]> > --- > drivers/gpu/drm/arc/arcpgu_drv.c | 1 - > drivers/gpu/drm/arm/hdlcd_drv.c | 1 - > drivers/gpu/drm/arm/malidp_drv.c | 1 - > drivers/gpu/drm/armada/armada_drv.c | 1 - > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 1 - > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 - > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 1 - > drivers/gpu/drm/i915/i915_irq.c | 1 - > drivers/gpu/drm/imx/imx-drm-core.c | 1 - > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > drivers/gpu/drm/meson/meson_drv.c | 1 - > drivers/gpu/drm/msm/msm_drv.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 - > drivers/gpu/drm/nouveau/nouveau_drm.c | 1 - > drivers/gpu/drm/omapdrm/omap_drv.c | 1 - > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 - > drivers/gpu/drm/sti/sti_drv.c | 1 - > drivers/gpu/drm/sun4i/sun4i_drv.c | 1 - > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 1 - > drivers/gpu/drm/vc4/vc4_drv.c | 1 - > drivers/gpu/drm/zte/zx_drm_drv.c | 1 - > 25 files changed, 25 deletions(-) [snip] > diff --git a/drivers/gpu/drm/i915/i915_irq.c > b/drivers/gpu/drm/i915/i915_irq.c index 47d6131e977f..5aab08172faf 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -4218,7 +4218,6 @@ void intel_irq_init(struct drm_i915_private *dev_priv) > if (IS_GEN2(dev_priv)) { > /* Gen2 doesn't have a hardware frame counter */ > dev->max_vblank_count = 0; > - dev->driver->get_vblank_counter = drm_vblank_no_hw_counter; > } else if (IS_G4X(dev_priv) || INTEL_INFO(dev_priv)->gen >= 5) { > dev->max_vblank_count = 0xffffffff; /* full 32 bit counter */ > dev->driver->get_vblank_counter = g4x_get_vblank_counter; On an unrelated note, for security reasons we should try to make the driver structure static, or at least move ops to a static structure. Anyway, for this patch, Reviewed-by: Laurent Pinchart <[email protected]> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
