Oh, and one more style comment below: On 08/07/2011 10:39 PM, Marek Olšák wrote:
+enum ttm_buffer_usage {
+ TTM_USAGE_READ = 1,
+ TTM_USAGE_WRITE = 2,
+ TTM_USAGE_READWRITE = TTM_USAGE_READ | TTM_USAGE_WRITE
+};
Please don't use enums for bit operations. #define TTM_USAGE_FLAG_READ (1 << 0) #define TTM_USAGE_FLAG_WRITE (1 << 1) /Thomas _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
